Fix Arabic locale currency parsing in accounting reports (OFBIZ-10155)#1240
Merged
dixitdeepak merged 1 commit intoMay 22, 2026
Merged
Conversation
Avoid pre-formatting invoice and payment amounts with NumberFormat before passing them to currency renderers. Keep values as BigDecimal so the existing currency display logic performs the final locale-aware formatting. This prevents Arabic digits from being HTML-escaped into values such as ٢٠ and then failing BigDecimal parsing during report rendering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid pre-formatting invoice and payment amounts with NumberFormat before passing them to currency renderers. Keep values as BigDecimal so the existing currency display logic performs the final locale-aware formatting.
This prevents Arabic digits from being HTML-escaped into values such as ٢٠ and then failing BigDecimal parsing during report rendering.
While reviewing the report forms, I found two field-name mismatches around the same not-applied invoice value: one AP grid computes outstanding but displays amountToApply, and the AR form computes amountToApply but displays outstanding. Corrected those alongside the locale-formatting fix so the computed value is actually the one rendered.
Thanks Aditya Sharma for reporting the issue.